Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix links resulting in 404 #17705

Merged
merged 19 commits into from
Aug 15, 2024
Merged

docs: Fix links resulting in 404 #17705

merged 19 commits into from
Aug 15, 2024

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Jul 25, 2024 •
edited
Loading

GitHub Issue (If applicable): part of https://github.com/unoplatform/private/issues/504, part of #15048

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Description

Fix links resulting in 404 for the documentation

PR Checklist

Please check if your PR fulfills the following requirements:

@morning4coffe-dev
Copy link
Member Author

morning4coffe-dev commented Jul 25, 2024 •
edited
Loading

There is currently a total of 220 broken links (some of which #17706, but not all) across our whole docs. Table of broken links is an internal issue https://github.com/unoplatform/private/issues/504

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@agneszitte
Copy link
Contributor

@morning4coffe-dev fyi @ajpinedam started this PR last year: https://github.com/unoplatform/uno/pull/14924/files#r1549699102

I think it will be good to close it and continue the work here. Also like @jeromelaban mentioned, best to use xref: links instead, wherever possible.

@agneszitte agneszitte added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@morning4coffe-dev
Copy link
Member Author

@agneszitte I think we can close too. And good point with the xref, I tried to use it as much as I could, but from looking at it now, I can use it on the updating-to-winui3.md and global.json probably too, I will adjust👍

@agneszitte agneszitte linked an issue Aug 1, 2024 that may be closed by this pull request
[Docs] Adjust publication to remove outdated docs and redirect to the proper default landing page #12356
Open
2 tasks
@agneszitte agneszitte removed a link to an issue Aug 1, 2024
[Docs] Adjust publication to remove outdated docs and redirect to the proper default landing page #12356
Open
2 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@morning4coffe-dev
Copy link
Member Author

As far as the list I generated, this PR should be complete. Other links will need to be adjusted in different repos.

@morning4coffe-dev morning4coffe-dev removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review August 9, 2024 07:25
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

agneszitte
agneszitte reviewed Aug 13, 2024
View reviewed changes
doc/articles/common-issues-all-ides.md Outdated Show resolved Hide resolved
doc/articles/migrating-from-xamarin-to-net6.md Outdated Show resolved Hide resolved
doc/articles/uno-development/building-uno-ui.md Outdated Show resolved Hide resolved
doc/articles/uno-development/contributing-intro.md Outdated Show resolved Hide resolved
doc/articles/uno-development/contributing-intro.md Outdated Show resolved Hide resolved
doc/articles/uno-development/contributing-intro.md Outdated Show resolved Hide resolved
doc/articles/uno-development/ways-to-contribute.md Outdated Show resolved Hide resolved
doc/blog/201809-uno-wasm-intro-part-01.md Outdated Show resolved Hide resolved
@agneszitte
Copy link
Contributor

@morning4coffe-dev fyi @ajpinedam started this PR last year: #14924 (files)

I think it will be good to close it and continue the work here. Also like @jeromelaban mentioned, best to use xref: links instead, wherever possible.

I think we can close too. And good point with the xref, I tried to use it as much as I could, but from looking at it now, I can use it on the updating-to-winui3.md and global.json probably too, I will adjust👍

@morning4coffe-dev can you merge the fixes that was started here https://github.com/unoplatform/uno/pull/14924/files#r1549699102 so we can close it please

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@morning4coffe-dev morning4coffe-dev mentioned this pull request Aug 15, 2024
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17705/index.html

@agneszitte agneszitte merged commit 58d4be2 into master Aug 15, 2024
14 checks passed
@agneszitte agneszitte deleted the dev/doti/docs-link-fixes branch August 15, 2024 17:45
@agneszitte
Copy link
Contributor

@Mergifyio backport release/stable/5.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 15, 2024 •
edited
Loading

backport release/stable/5.3

❌ No backport have been created

  • Backport to branch release/stable/5.3 failed

Git reported the following error:

error: commit 4b12dcc42c7b9998601993b3a697f549437e0870 is a merge but no -m option was given.
fatal: cherry-pick failed

@morning4coffe-dev morning4coffe-dev mentioned this pull request Aug 15, 2024
Closed
6 tasks
@agneszitte agneszitte mentioned this pull request Aug 15, 2024
Merged
agneszitte added a commit that referenced this pull request Aug 15, 2024
@agneszitte
Merge pull request #17955 from unoplatform/dev/agzi/BackportPR17705
d240b5b 
docs: Fix links resulting in 404 (Backport #17705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees
No one assigned
Labels
kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morning4coffe-dev @unodevops @agneszitte @jeromelaban @Youssef1313